Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js tests for accordion component #1977

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Add js tests for accordion component #1977

merged 1 commit into from
Mar 18, 2021

Conversation

owenatgov
Copy link
Contributor

What

Adds Jasmine tests for the accordion js

Why

Addresses #1960

No visual changes

@bevanloon bevanloon temporarily deployed to govuk-publis-accordion--5jd0zv March 16, 2021 13:59 Inactive
@owenatgov owenatgov force-pushed the accordion-js-tests branch from 2c892d0 to 7ead6d2 Compare March 16, 2021 14:00
@bevanloon bevanloon temporarily deployed to govuk-publis-accordion--5jd0zv March 16, 2021 14:00 Inactive
@bevanloon bevanloon temporarily deployed to govuk-publis-accordion--5jd0zv March 16, 2021 17:05 Inactive
Copy link
Contributor

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, Owen! Thank you for looking into this.
Don't forget to squash the commits before merging.

@owenatgov owenatgov force-pushed the accordion-js-tests branch from dd11a24 to 43a5bb9 Compare March 18, 2021 15:49
@bevanloon bevanloon temporarily deployed to govuk-publis-accordion--5jd0zv March 18, 2021 15:50 Inactive
@owenatgov owenatgov merged commit 7ec04ab into master Mar 18, 2021
@owenatgov owenatgov deleted the accordion-js-tests branch March 18, 2021 15:59
alex-ju added a commit that referenced this pull request Mar 19, 2021
* Add GOVUK Frontend Details module to GOVUK Modules and amend `modules.js` start function ([PR #1985](#1985))
* Rescope Brexit CTA to en/cy locale only ([PR #1984](#1984))
* Add JavaScript tests for accordion component ([PR #1977](#1977))
* Fix search component label background ([PR #1983](#1983))
* Allow emergency banner and global bar in public layout component ([PR #1978](#1915))
@alex-ju alex-ju mentioned this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants